chore: convert tests to use in memory ipld #4
Conversation
ghost
assigned 
|
@achingbrain As you don't do anything special in your |
|
|
||
| pull( | ||
| values([ | ||
| { path: 'a/b/c/d/e', content: pull.values([Buffer.from('banana')]) }, |
There was a problem hiding this comment.
This is an exemplarily comment. There's some calls with pull.* in the tests. I don't have a clue why they work. I made some code changes on top of this PR and then the tests failed for me.
Anyway, I guess it makes sense to replace all occurrences of pull.* with there * counterparts.
There was a problem hiding this comment.
Interesting. I'm going to merge this PR, will do another with the pull.* to * change, otherwise this runs the risk of becoming a 'general improvements' thread.
What were the changes you made that meant these tests stop working?
There was a problem hiding this comment.
I tried to find out what made things not working, but I couldn't. It is during my IPLD API changes stuff, so it's a lot of dependencies changing and also a lot of linking involved. Hence hard to tell what made it fail.
Ah, cool - I thought they were required by Aegir. I guess they're only necessary if your tests aren't called |
Exactly! |
Also renames
.jstests to.spec.jsand removes some unused dependencies frompackage.json.